Move Transmissive3d phase to pbr/transmission #22706
Merged
+151
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlv24
commented
Jan 25, 2026
| for (_, camera, extracted_view, depth_prepass, camera_3d, _msaa) in &views_3d { | ||
| if !opaque_3d_phases.contains_key(&extracted_view.retained_view_entity) | ||
| || !alpha_mask_3d_phases.contains_key(&extracted_view.retained_view_entity) | ||
| || !transmissive_3d_phases.contains_key(&extracted_view.retained_view_entity) |
Contributor
Author
There was a problem hiding this comment.
Note: i don't know what this check is here for. All of these contains_key checks always return true and the conditional never runs in my testing.
Contributor
Author
There was a problem hiding this comment.
Checking if this even does anything at all in #22711
atlv24
added
A-Rendering
alice-i-cecile
requested changes
Jan 26, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good change, but missing a migration guide :P
alice-i-cecile
added
C-Code-Quality
kfc35
approved these changes
Jan 26, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
looks good to me logic wise
alice-i-cecile
added
X-Uncontroversial
atlv24
added
S-Needs-Review
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing